Page MenuHomePhabricator
Differential D6497

rpc: migrate JSONRPCRequest functionality into request.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 10 2020, 12:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd4d128d90df4: rpc: migrate JSONRPCRequest functionality into request.cpp
Summary

This si a partial backport of Core PR16240 : https://github.com/bitcoin/bitcoin/pull/16240/commits/5c5e32bbe3dfa790dd8bb421fbd6301ae10b09f5

Depends on D6496

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 10 2020, 12:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2020, 12:46
deadalnix requested review of this revision.Jun 10 2020, 12:46
teamcity edited the summary of this revision. (Show Details)Jun 10 2020, 12:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix edited the summary of this revision. (Show Details)Jun 10 2020, 12:48
deadalnix added a parent revision: D6496: Move jsonrpcrequest to request.
deadalnix added a child revision: D6498: Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper.Jun 10 2020, 12:55
Harbormaster completed remote builds in B11381: Diff 21214.Jun 10 2020, 12:58
Fabien requested changes to this revision.Jun 10 2020, 13:32
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/Makefile.am
216 ↗(On Diff #21214)

They are duplicates. Hard to detect because register.h is not ordered correctly

This revision now requires changes to proceed.Jun 10 2020, 13:32
deadalnix updated this revision to Diff 21222.Jun 10 2020, 14:33

Fix Makefile.am

Harbormaster completed remote builds in B11388: Diff 21222.Jun 10 2020, 14:52
Fabien accepted this revision.Jun 10 2020, 18:48
This revision is now accepted and ready to land.Jun 10 2020, 18:48
Closed by commit rABCd4d128d90df4: rpc: migrate JSONRPCRequest functionality into request.cpp (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 10 2020, 20:44
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd4d128d90df4: rpc: migrate JSONRPCRequest functionality into request.cpp.

Revision Contents
Changeset List

Diff 21241

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/protocol.h

Loading...
View Options

src/rpc/protocol.cpp

Loading...
View Options

src/rpc/rawtransaction_util.cpp

Loading...
View Options

src/rpc/request.h

Loading...
View Options

src/rpc/request.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/test/rpc_server_tests.cpp

Loading...