Differential D6497

rpc: migrate JSONRPCRequest functionality into request.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 10 2020, 12:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd4d128d90df4: rpc: migrate JSONRPCRequest functionality into request.cpp

Summary

This si a partial backport of Core PR16240 : https://github.com/bitcoin/bitcoin/pull/16240/commits/5c5e32bbe3dfa790dd8bb421fbd6301ae10b09f5

Depends on D6496

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16240-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11381
Build 21702: Default Diff Build & Tests
Build 21701: Build without Wallet
Build 21700: Build with clang-10
Build 21699: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 10 2020, 12:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2020, 12:46

deadalnix requested review of this revision.Jun 10 2020, 12:46

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix edited the summary of this revision. (Show Details)Jun 10 2020, 12:48

deadalnix added a parent revision: D6496: Move jsonrpcrequest to request.

deadalnix added a child revision: D6498: Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper.Jun 10 2020, 12:55

Harbormaster completed remote builds in B11381: Diff 21214.Jun 10 2020, 12:58

Fabien requested changes to this revision.Jun 10 2020, 13:32

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/Makefile.am
216	They are duplicates. Hard to detect because register.h is not ordered correctly

This revision now requires changes to proceed.Jun 10 2020, 13:32

Fix Makefile.am

Harbormaster completed remote builds in B11388: Diff 21222.Jun 10 2020, 14:52

Fabien accepted this revision.Jun 10 2020, 18:48

This revision is now accepted and ready to land.Jun 10 2020, 18:48

Closed by commit rABCd4d128d90df4: rpc: migrate JSONRPCRequest functionality into request.cpp (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 10 2020, 20:44

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd4d128d90df4: rpc: migrate JSONRPCRequest functionality into request.cpp.

Revision Contents
Changeset List

Path

Size

src/

3 lines

5 lines

1 line

1 line

rpc/

protocol.h

26 lines

protocol.cpp

rawtransaction_util.cpp

2 lines

request.h

17 lines

request.cpp

151 lines

server.h

8 lines

test/

rpc_server_tests.cpp

1 line

Diff 21214

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/bitcoin-cli.cpp

View Options

src/rest.cpp

View Options

src/rpc/protocol.h

View Options

src/rpc/protocol.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/request.h

View Options

src/rpc/request.cpp

View Options

src/rpc/server.h

View Options

src/test/rpc_server_tests.cpp

rpc: migrate JSONRPCRequest functionality into request.cppClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21214

src/CMakeLists.txt

src/Makefile.am

src/bitcoin-cli.cpp

src/rest.cpp

src/rpc/protocol.h

src/rpc/protocol.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/request.h

src/rpc/request.cpp

src/rpc/server.h

src/test/rpc_server_tests.cpp

rpc: migrate JSONRPCRequest functionality into request.cpp
ClosedPublic
Actions

Revision Contents
Changeset List