Differential D6544

[CMAKE] Don't require jemalloc for systems where it's the default
ClosedPublic
Actions

Authored by Fabien on Jun 12 2020, 09:07.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCae5e07f4111a: [CMAKE] Don't require jemalloc for systems where it's the default

Summary

On these system there is no need to pull jemalloc as a 3rd party lib
since it's the built-in default. This fixes the build on FreeBSD.

Test Plan

Build on Linux and check jemalloc is required by default.

cmake -GNinja .. -DUSE_JEMALLOC=OFF

Check disabling jemalloc manually still works as expected.

Build on FreeBSD and check the build succeeds (tested without Qt as per our documentation).

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 12 2020, 09:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 09:07

Fabien requested review of this revision.Jun 12 2020, 09:07

Fabien edited the test plan for this revision. (Show Details)Jun 12 2020, 09:10

Harbormaster completed remote builds in B11439: Diff 21316.Jun 12 2020, 09:20

deadalnix accepted this revision.Jun 12 2020, 12:25

This revision is now accepted and ready to land.Jun 12 2020, 12:25

Closed by commit rABCae5e07f4111a: [CMAKE] Don't require jemalloc for systems where it's the default (authored by Fabien). · Explain WhyJun 12 2020, 16:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCae5e07f4111a: [CMAKE] Don't require jemalloc for systems where it's the default.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

11 lines

Diff 21324

View Options

[CMAKE] Don't require jemalloc for systems where it's the defaultClosedPublicActions