Differential D6554

[backport#16227 2/8] Remove CKeyStore and squash into CBasicKeyStore
ClosedPublic
Actions

Authored by majcosta on Jun 12 2020, 18:58.

Details

Reviewers

nakihito

Group Reviewers

Restricted Project

Commits

rABCb2849c3abc97: [backport#16227 2/8] Remove CKeyStore and squash into CBasicKeyStore

Summary

https://github.com/bitcoin/bitcoin/pull/16227/commits/c7797ec65544bd23a2e571b2892e1bf512f2a485

Depends on D6553

Partial backport of Core PR16227

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11451
Build 21955: Default Diff Build & Tests	Link to the build
Build 21954: Build without Wallet	Link to the build
Build 21953: Build with clang-10	Link to the build
Build 21952: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 12 2020, 18:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 18:58

majcosta requested review of this revision.Jun 12 2020, 18:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta retitled this revision from Remove CKeyStore and squash into CBasicKeyStore to [backport#16227 2/8] Remove CKeyStore and squash into CBasicKeyStore.Jun 12 2020, 18:58

majcosta added a child revision: D6555: [backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet where it is used.Jun 12 2020, 19:01

Harbormaster completed remote builds in B11451: Diff 21334.Jun 12 2020, 19:19

nakihito accepted this revision.Jun 12 2020, 19:59

This revision is now accepted and ready to land.Jun 12 2020, 19:59

Closed by commit rABCb2849c3abc97: [backport#16227 2/8] Remove CKeyStore and squash into CBasicKeyStore (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJun 13 2020, 20:13

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCb2849c3abc97: [backport#16227 2/8] Remove CKeyStore and squash into CBasicKeyStore.