Differential D6555

[backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet where it is used
ClosedPublic
Actions

Authored by majcosta on Jun 12 2020, 19:01.

Details

Reviewers

nakihito

Group Reviewers

Restricted Project

Commits

rABCf8cec7b82ac6: [backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet…

Summary

https://github.com/bitcoin/bitcoin/pull/16227/commits/a913e3f2fbeb1352fc66f334d4f5f7332ea89ad7

Depends on D6554

Partial backport of Core PR16227

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11452
Build 21959: Default Diff Build & Tests	Link to the build
Build 21958: Build without Wallet	Link to the build
Build 21957: Build with clang-10	Link to the build
Build 21956: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 12 2020, 19:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 19:01

majcosta requested review of this revision.Jun 12 2020, 19:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6556: [backport#16227 4/8] scripted-diff: rename CBasicKeyStore to FillableSigningProvider.Jun 12 2020, 19:03

Harbormaster completed remote builds in B11452: Diff 21335.Jun 12 2020, 19:20

nakihito accepted this revision.Jun 12 2020, 20:03

This revision is now accepted and ready to land.Jun 12 2020, 20:03

Closed by commit rABCf8cec7b82ac6: [backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJun 13 2020, 20:14

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCf8cec7b82ac6: [backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet….

Revision Contents
Changeset List

Path

Size

src/

keystore.h

5 lines

keystore.cpp

7 lines

wallet/

rpcwallet.cpp

10 lines

Diff 21335

View Options

src/keystore.h

View Options

src/keystore.cpp

View Options

[backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet where it is usedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21335

src/keystore.h

src/keystore.cpp

src/wallet/rpcwallet.cpp

[backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet where it is used
ClosedPublic
Actions

Revision Contents
Changeset List