Page MenuHomePhabricator
Differential D6561

[backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet
ClosedPublic
Actions

Authored by majcosta on Jun 12 2020, 22:28.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rABC4a64e22d3a55: [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet
Summary

https://github.com/bitcoin/bitcoin/pull/16227/commits/93ce4a0b6fb54efb1f424a71dfc09cc33307e5b9?file-filters%5B%5D=.h#diff-12635a58447c65585f51d32b7e04075bR1051

Depends on D6560

Concludes backport of Core PR16227

Test Plan
ninja check-all

Diff Detail

Event Timeline

majcosta created this revision.Jun 12 2020, 22:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 22:28
majcosta requested review of this revision.Jun 12 2020, 22:28
teamcity edited the summary of this revision. (Show Details)Jun 12 2020, 22:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta retitled this revision from [backport#16227] Move WatchOnly stuff from SigningProvider to CWallet to [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet.Jun 12 2020, 22:28
Harbormaster completed remote builds in B11463: Diff 21347.Jun 12 2020, 22:39
nakihito requested changes to this revision.Jun 13 2020, 01:31
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/script/signingprovider.cpp
88–89

This stays.

This revision now requires changes to proceed.Jun 13 2020, 01:31
nakihito added inline comments.Jun 13 2020, 01:55
src/script/signingprovider.cpp
86–101

Discussed offline. This is only used for witness stuff in Core even now. Remove entirely.

majcosta updated this revision to Diff 21351.Jun 13 2020, 02:41

removed unused function ImplicitlyLearnRelatedKeyScripts

teamcity added a comment.Jun 13 2020, 02:43
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[02:42:47] :	 [Step 1/2] [375/412] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/__/test/util/setup_common.cpp.o
[02:42:47] :	 [Step 1/2] [376/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bantablemodel.cpp.o
[02:42:47] :	 [Step 1/2] [377/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/clientmodel.cpp.o
[02:42:48] :	 [Step 1/2] [378/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/guiutil.cpp.o
[02:42:48] :	 [Step 1/2] [379/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/networkstyle.cpp.o
[02:42:48] :	 [Step 1/2] [380/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinaddressvalidator.cpp.o
[02:42:48] :	 [Step 1/2] [381/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/modaloverlay.cpp.o
[02:42:48] :	 [Step 1/2] [382/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/intro.cpp.o
[02:42:48] :	 [Step 1/2] [383/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/csvmodelwriter.cpp.o
[02:42:48] :	 [Step 1/2] [384/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinunits.cpp.o
[02:42:49] :	 [Step 1/2] [385/412] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/ccoins_caching.cpp.o
[02:42:49] :	 [Step 1/2] [386/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/peertablemodel.cpp.o
[02:42:50] :	 [Step 1/2] [387/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinamountfield.cpp.o
[02:42:50] :	 [Step 1/2] [388/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/platformstyle.cpp.o
[02:42:50] :	 [Step 1/2] [389/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/trafficgraphwidget.cpp.o
[02:42:50] :	 [Step 1/2] [390/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qvalidatedlineedit.cpp.o
[02:42:51] :	 [Step 1/2] [391/412] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/rpc_mempool.cpp.o
[02:42:51] :	 [Step 1/2] [392/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qvaluecombobox.cpp.o
[02:42:51] :	 [Step 1/2] [393/412] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/mempool_eviction.cpp.o
[02:42:51] :	 [Step 1/2] [394/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin.cpp.o
[02:42:52] :	 [Step 1/2] [395/412] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/__/test/util.cpp.o
[02:42:52] :	 [Step 1/2] [396/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o
[02:42:52] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o 
[02:42:52] :	 [Step 1/2] /usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o -c ../src/qt/bitcoingui.cpp
[02:42:52] :	 [Step 1/2] ../src/qt/bitcoingui.cpp: In member function 'void BitcoinGUI::updateProxyIcon()':
[02:42:52] :	 [Step 1/2] ../src/qt/bitcoingui.cpp:1364:40: error: 'ReturnByValue' is not a member of 'Qt'
[02:42:52] :	 [Step 1/2]          if (labelProxyIcon->pixmap(Qt::ReturnByValue).isNull()) {
[02:42:52] :	 [Step 1/2]                                         ^~~~~~~~~~~~~
[02:42:52] :	 [Step 1/2] [397/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/notificator.cpp.o
[02:42:53] :	 [Step 1/2] [398/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o
[02:42:53] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o 
[02:42:53] :	 [Step 1/2] /usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o -c ../src/qt/optionsmodel.cpp
[02:42:53] :	 [Step 1/2] ../src/qt/optionsmodel.cpp: In function 'ProxySetting GetProxySetting(QSettings&, const QString&)':
[02:42:53] :	 [Step 1/2] ../src/qt/optionsmodel.cpp:273:56: error: 'SkipEmptyParts' is not a member of 'Qt'
[02:42:53] :	 [Step 1/2]          settings.value(name).toString().split(":", Qt::SkipEmptyParts);
[02:42:53] :	 [Step 1/2]                                                         ^~~~~~~~~~~~~~
[02:42:55] :	 [Step 1/2] [399/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin.cpp.o
[02:42:55] :	 [Step 1/2] [400/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/utilitydialog.cpp.o
[02:42:55] :	 [Step 1/2] [401/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsdialog.cpp.o
[02:42:56] :	 [Step 1/2] [402/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin-qt-base_autogen/mocs_compilation.cpp.o
[02:42:56] :	 [Step 1/2] [403/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o
[02:42:56] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o 
[02:42:56] :	 [Step 1/2] /usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o -c ../src/qt/rpcconsole.cpp
[02:42:56] :	 [Step 1/2] ../src/qt/rpcconsole.cpp: In member function 'void RPCConsole::setClientModel(ClientModel*)':
[02:42:56] :	 [Step 1/2] ../src/qt/rpcconsole.cpp:727:47: error: 'mappedInt' is not a member of 'QSignalMapper'
[02:42:56] :	 [Step 1/2]          connect(signalMapper, &QSignalMapper::mappedInt, this,
[02:42:56] :	 [Step 1/2]                                                ^~~~~~~~~
[02:42:56] :	 [Step 1/2] [404/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin_locale.cpp.o
[02:42:56] :	 [Step 1/2] [405/412] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/bench.cpp.o
[02:42:56] :	 [Step 1/2] [406/412] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/splashscreen.cpp.o
[02:42:56] :	 [Step 1/2] ninja: build stopped: subcommand failed.
[02:42:56] :	 [Step 1/2] *** Output of /tmp/sanitizer_logs/*.log.* ***
[02:42:56]W:	 [Step 1/2] ++ print_sanitizers_log
[02:42:56]W:	 [Step 1/2] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[02:42:56]W:	 [Step 1/2] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[02:42:56]W:	 [Step 1/2] ++ cat '/tmp/sanitizer_logs/*.log.*'
[02:42:56]W:	 [Step 1/2] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[02:42:57]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[02:43:02]W:	 [Step 1/2] Process exited with code 1
[02:43:02]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
Harbormaster completed remote builds in B11464: Diff 21351.Jun 13 2020, 02:43
teamcity added a comment.Jun 13 2020, 02:43
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[02:43:05] :	 [Step 1/2] [425/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/__/test/util.cpp.o
[02:43:07] :	 [Step 1/2] [426/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/utilitydialog.cpp.o
[02:43:07] :	 [Step 1/2] [427/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/coin_selection.cpp.o
[02:43:08] :	 [Step 1/2] [428/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/wallet_balance.cpp.o
[02:43:08] :	 [Step 1/2] [429/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o
[02:43:08] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o 
[02:43:08] :	 [Step 1/2] /usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o -c ../src/qt/bitcoingui.cpp
[02:43:08] :	 [Step 1/2] ../src/qt/bitcoingui.cpp: In member function 'void BitcoinGUI::updateProxyIcon()':
[02:43:08] :	 [Step 1/2] ../src/qt/bitcoingui.cpp:1364:40: error: 'ReturnByValue' is not a member of 'Qt'
[02:43:08] :	 [Step 1/2]          if (labelProxyIcon->pixmap(Qt::ReturnByValue).isNull()) {
[02:43:08] :	 [Step 1/2]                                         ^~~~~~~~~~~~~
[02:43:08] :	 [Step 1/2] [430/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o
[02:43:08] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o 
[02:43:08] :	 [Step 1/2] /usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o -c ../src/qt/receiverequestdialog.cpp
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp: In member function 'QImage QRImageWidget::exportImage()':
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp:44:20: error: 'ReturnByValue' is not a member of 'Qt'
[02:43:08] :	 [Step 1/2]      if (pixmap(Qt::ReturnByValue).isNull()) {
[02:43:08] :	 [Step 1/2]                     ^~~~~~~~~~~~~
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp:47:23: error: 'ReturnByValue' is not a member of 'Qt'
[02:43:08] :	 [Step 1/2]      return pixmap(Qt::ReturnByValue).toImage();
[02:43:08] :	 [Step 1/2]                        ^~~~~~~~~~~~~
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp: In member function 'virtual void QRImageWidget::mousePressEvent(QMouseEvent*)':
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp:52:21: error: 'ReturnByValue' is not a member of 'Qt'
[02:43:08] :	 [Step 1/2]          !pixmap(Qt::ReturnByValue).isNull()) {
[02:43:08] :	 [Step 1/2]                      ^~~~~~~~~~~~~
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp: In member function 'void QRImageWidget::saveImage()':
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp:66:20: error: 'ReturnByValue' is not a member of 'Qt'
[02:43:08] :	 [Step 1/2]      if (pixmap(Qt::ReturnByValue).isNull()) {
[02:43:08] :	 [Step 1/2]                     ^~~~~~~~~~~~~
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp: In member function 'void QRImageWidget::copyImage()':
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp:77:20: error: 'ReturnByValue' is not a member of 'Qt'
[02:43:08] :	 [Step 1/2]      if (pixmap(Qt::ReturnByValue).isNull()) {
[02:43:08] :	 [Step 1/2]                     ^~~~~~~~~~~~~
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp: In member function 'virtual void QRImageWidget::contextMenuEvent(QContextMenuEvent*)':
[02:43:08] :	 [Step 1/2] ../src/qt/receiverequestdialog.cpp:84:20: error: 'ReturnByValue' is not a member of 'Qt'
[02:43:08] :	 [Step 1/2]      if (pixmap(Qt::ReturnByValue).isNull()) {
[02:43:08] :	 [Step 1/2]                     ^~~~~~~~~~~~~
[02:43:09] :	 [Step 1/2] [431/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o
[02:43:09] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o 
[02:43:09] :	 [Step 1/2] /usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o -c ../src/qt/rpcconsole.cpp
[02:43:09] :	 [Step 1/2] ../src/qt/rpcconsole.cpp: In member function 'void RPCConsole::setClientModel(ClientModel*)':
[02:43:09] :	 [Step 1/2] ../src/qt/rpcconsole.cpp:727:47: error: 'mappedInt' is not a member of 'QSignalMapper'
[02:43:09] :	 [Step 1/2]          connect(signalMapper, &QSignalMapper::mappedInt, this,
[02:43:09] :	 [Step 1/2]                                                ^~~~~~~~~
[02:43:09] :	 [Step 1/2] [432/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin_locale.cpp.o
[02:43:10] :	 [Step 1/2] [433/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addresstablemodel.cpp.o
[02:43:10] :	 [Step 1/2] [434/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin.cpp.o
[02:43:12] :	 [Step 1/2] [435/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroldialog.cpp.o
[02:43:12] :	 [Step 1/2] [436/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receivecoinsdialog.cpp.o
[02:43:12] :	 [Step 1/2] [437/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentserver.cpp.o
[02:43:12] :	 [Step 1/2] ninja: build stopped: subcommand failed.
[02:43:12] :	 [Step 1/2] *** Output of /tmp/sanitizer_logs/*.log.* ***
[02:43:12]W:	 [Step 1/2] ++ print_sanitizers_log
[02:43:12]W:	 [Step 1/2] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[02:43:12]W:	 [Step 1/2] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[02:43:12]W:	 [Step 1/2] ++ cat '/tmp/sanitizer_logs/*.log.*'
[02:43:12]W:	 [Step 1/2] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[02:43:13]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[02:43:29]W:	 [Step 1/2] Process exited with code 1
[02:43:29]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
teamcity added a comment.Jun 13 2020, 02:44
Build Bitcoin ABC Diffs / Diff Testing (build-clang-10) failed.

Snippet of first build failure:

[02:43:56] :	 [Step 1/2] [394/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/duplicate_inputs.cpp.o
[02:43:58] :	 [Step 1/2] [395/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/mempool_eviction.cpp.o
[02:43:58] :	 [Step 1/2] [396/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/rpc_mempool.cpp.o
[02:43:58] :	 [Step 1/2] [397/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinamountfield.cpp.o
[02:43:58] :	 [Step 1/2] [398/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinaddressvalidator.cpp.o
[02:43:59] :	 [Step 1/2] [399/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoinunits.cpp.o
[02:44:00] :	 [Step 1/2] [400/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bantablemodel.cpp.o
[02:44:00] :	 [Step 1/2] [401/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/csvmodelwriter.cpp.o
[02:44:01] :	 [Step 1/2] [402/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/networkstyle.cpp.o
[02:44:01] :	 [Step 1/2] [403/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/__/test/util.cpp.o
[02:44:01] :	 [Step 1/2] [404/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/bench.cpp.o
[02:44:02] :	 [Step 1/2] [405/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/clientmodel.cpp.o
[02:44:02] :	 [Step 1/2] [406/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/modaloverlay.cpp.o
[02:44:03] :	 [Step 1/2] [407/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/notificator.cpp.o
[02:44:03] :	 [Step 1/2] [408/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o
[02:44:03] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o 
[02:44:03] :	 [Step 1/2] /usr/bin/ccache /usr/bin/clang++-10  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety-analysis -Wshadow -Wrange-loop-analysis -Wredundant-decls -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o -c ../src/qt/bitcoingui.cpp
[02:44:03] :	 [Step 1/2] ../src/qt/bitcoingui.cpp:1364:40: error: no member named 'ReturnByValue' in namespace 'Qt'
[02:44:03] :	 [Step 1/2]         if (labelProxyIcon->pixmap(Qt::ReturnByValue).isNull()) {
[02:44:03] :	 [Step 1/2]                                    ~~~~^
[02:44:03] :	 [Step 1/2] 1 error generated.
[02:44:04] :	 [Step 1/2] [409/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/platformstyle.cpp.o
[02:44:04] :	 [Step 1/2] [410/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/wallet_balance.cpp.o
[02:44:04] :	 [Step 1/2] [411/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qvalidatedlineedit.cpp.o
[02:44:04] :	 [Step 1/2] [412/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/__/test/util/setup_common.cpp.o
[02:44:04] :	 [Step 1/2] [413/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/intro.cpp.o
[02:44:05] :	 [Step 1/2] [414/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin.cpp.o
[02:44:05] :	 [Step 1/2] [415/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qvaluecombobox.cpp.o
[02:44:05] :	 [Step 1/2] [416/460] Building CXX object src/bench/CMakeFiles/bitcoin-bench.dir/coin_selection.cpp.o
[02:44:05] :	 [Step 1/2] [417/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o
[02:44:05] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o 
[02:44:05] :	 [Step 1/2] /usr/bin/ccache /usr/bin/clang++-10  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety-analysis -Wshadow -Wrange-loop-analysis -Wredundant-decls -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o -c ../src/qt/optionsmodel.cpp
[02:44:05] :	 [Step 1/2] ../src/qt/optionsmodel.cpp:273:56: error: no member named 'SkipEmptyParts' in namespace 'Qt'
[02:44:05] :	 [Step 1/2]         settings.value(name).toString().split(":", Qt::SkipEmptyParts);
[02:44:05] :	 [Step 1/2]                                                    ~~~~^
[02:44:05] :	 [Step 1/2] 1 error generated.
[02:44:06] :	 [Step 1/2] [418/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/guiutil.cpp.o
[02:44:06] :	 [Step 1/2] [419/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsdialog.cpp.o
[02:44:06] :	 [Step 1/2] [420/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/peertablemodel.cpp.o
[02:44:08] :	 [Step 1/2] [421/460] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o
[02:44:08] :	 [Step 1/2] FAILED: src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o 
[02:44:08] :	 [Step 1/2] /usr/bin/ccache /usr/bin/clang++-10  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DHAVE_DECL_EVP_MD_CTX_NEW=1 -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DUSE_PROTOBUF_MESSAGE_BYTESIZELONG -Isrc/qt/bitcoin-qt-base_autogen/include -I../src/. -Isrc -I../src/univalue/include -Isrc/crypto/.. -I../src/secp256k1/include -I../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety-analysis -Wshadow -Wrange-loop-analysis -Wredundant-decls -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -fPIC -std=gnu++14 -MD -MT src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o -MF src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o.d -o src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o -c ../src/qt/rpcconsole.cpp
[02:44:08] :	 [Step 1/2] ../src/qt/rpcconsole.cpp:727:32: error: no member named 'mappedInt' in 'QSignalMapper'; did you mean '::QSignalMapper::mapped'?
[02:44:08] :	 [Step 1/2]         connect(signalMapper, &QSignalMapper::mappedInt, this,
[02:44:08] :	 [Step 1/2]                                ^~~~~~~~~~~~~~~~~~~~~~~~
[02:44:08] :	 [Step 1/2]                                ::QSignalMapper::mapped
[02:44:08] :	 [Step 1/2] /usr/include/x86_64-linux-gnu/qt5/QtCore/qsignalmapper.h:71:10: note: '::QSignalMapper::mapped' declared here
[02:44:08] :	 [Step 1/2]     void mapped(int);
[02:44:08] :	 [Step 1/2]          ^
[02:44:08] :	 [Step 1/2] 1 error generated.
[02:44:08] :	 [Step 1/2] ninja: build stopped: subcommand failed.
[02:44:08] :	 [Step 1/2] *** Output of /tmp/sanitizer_logs/*.log.* ***
[02:44:08]W:	 [Step 1/2] ++ print_sanitizers_log
[02:44:08]W:	 [Step 1/2] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[02:44:08]W:	 [Step 1/2] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[02:44:08]W:	 [Step 1/2] ++ cat '/tmp/sanitizer_logs/*.log.*'
[02:44:08]W:	 [Step 1/2] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[02:44:09]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[02:44:13]W:	 [Step 1/2] Process exited with code 1
[02:44:13]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
majcosta updated this revision to Diff 21352.Jun 13 2020, 05:53

rebase

Harbormaster completed remote builds in B11465: Diff 21352.Jun 13 2020, 06:04
nakihito accepted this revision.Jun 15 2020, 01:51
This revision is now accepted and ready to land.Jun 15 2020, 01:51
Closed by commit rABC4a64e22d3a55: [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJun 15 2020, 15:00
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC4a64e22d3a55: [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet.

Revision Contents
Changeset List

PathSize
src/
script/
9 lines
62 lines
wallet/
16 lines
72 lines

Diff 21347

View Options

src/script/signingprovider.h

Loading...
View Options

src/script/signingprovider.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...