Page MenuHomePhabricator
Differential D6587

[backport#16917] tests: Move common function assert_approx() into util.py
ClosedPublic
Actions

Authored by majcosta on Jun 15 2020, 18:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC2dca88b1aefc: [backport#16917] tests: Move common function assert_approx() into util.py
Summary

96299a9d6c0a6b9125a58a63ee3147e55d1b086b Test: Move common function assert_approx() into util.py (fridokus)

Pull request description:

To reduce code duplication, move `assert_approx` into common framework `util.py`.

`assert_approx()` is used in two functional tests.

Backport of Core PR16917

Test Plan
test_runner.py wallet_avoidreuse wallet_groups

Diff Detail

Event Timeline

majcosta created this revision.Jun 15 2020, 18:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 18:48
majcosta requested review of this revision.Jun 15 2020, 18:48
teamcity edited the summary of this revision. (Show Details)Jun 15 2020, 18:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11499: Diff 21413.Jun 15 2020, 19:06
deadalnix accepted this revision.Jun 15 2020, 20:45
This revision is now accepted and ready to land.Jun 15 2020, 20:45
Closed by commit rABC2dca88b1aefc: [backport#16917] tests: Move common function assert_approx() into util.py (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyJun 15 2020, 20:59
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC2dca88b1aefc: [backport#16917] tests: Move common function assert_approx() into util.py.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
10 lines
12 lines
10 lines

Diff 21413

View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/wallet_avoidreuse.py

Loading...
View Options

test/functional/wallet_groups.py

Loading...