Page MenuHomePhabricator
Differential D6601

[backport#15368] Add getdescriptorinfo to compute checksum
ClosedPublic
Actions

Authored by majcosta on Jun 15 2020, 23:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0cb1527a7708: [backport#15368] Add getdescriptorinfo to compute checksum
Summary

https://github.com/bitcoin/bitcoin/pull/15368/commits/b52cb6368869c9f6dd2cd8f309b3000de514d439

Depends on D6600

Partial backport of Core PR15368

Test Plan
ninja
test_runner.py wallet_address_types

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 15 2020, 23:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 23:41
majcosta requested review of this revision.Jun 15 2020, 23:41
teamcity edited the summary of this revision. (Show Details)Jun 15 2020, 23:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6602: [backport#15368] Make descriptor checksums mandatory in deriveaddresses and importmulti.Jun 15 2020, 23:43
Harbormaster completed remote builds in B11515: Diff 21446.Jun 16 2020, 00:06
majcosta planned changes to this revision.Jun 16 2020, 00:07
majcosta updated this revision to Diff 21448.Jun 16 2020, 00:15

converted RPCHelpMan to use Check(JSONRPCRequest) functionality

Harbormaster completed remote builds in B11517: Diff 21448.Jun 16 2020, 00:28
Fabien accepted this revision.Jun 16 2020, 08:01
This revision is now accepted and ready to land.Jun 16 2020, 08:01
majcosta updated this revision to Diff 21484.Jun 17 2020, 14:42

rebase

Harbormaster completed remote builds in B11541: Diff 21484.Jun 17 2020, 14:55
Closed by commit rABC0cb1527a7708: [backport#15368] Add getdescriptorinfo to compute checksum (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 17 2020, 15:36
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC0cb1527a7708: [backport#15368] Add getdescriptorinfo to compute checksum.

Revision Contents
Changeset List

PathSize
src/
rpc/
45 lines
test/
functional/
4 lines

Diff 21487

View Options

src/rpc/misc.cpp

Loading...
View Options

test/functional/wallet_address_types.py

Loading...