Page MenuHomePhabricator
Differential D6602

[backport#15368] Make descriptor checksums mandatory in deriveaddresses and importmulti
ClosedPublic
Actions

Authored by majcosta on Jun 15 2020, 23:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8c72f636c0ca: [backport#15368] Make descriptor checksums mandatory in deriveaddresses and…
Summary

https://github.com/bitcoin/bitcoin/pull/15368/commits/be62903c417293f6217e124669e62fd2172a18f1

Depends on D6601

Partial backport of Core PR15368

Test Plan
ninja
test_runner.py rpc_deriveaddresses wallet_importmulti

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 15 2020, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 23:43
majcosta requested review of this revision.Jun 15 2020, 23:43
teamcity edited the summary of this revision. (Show Details)Jun 15 2020, 23:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11516: Diff 21447.Jun 16 2020, 00:02
Fabien requested changes to this revision.Jun 16 2020, 08:10
Fabien added a subscriber: Fabien.

Is it possible to adapt the test to cover the bad checksum case when importing using a descriptor ?

This revision now requires changes to proceed.Jun 16 2020, 08:10
majcosta updated this revision to Diff 21466.Jun 16 2020, 17:49

added test for importmulti of a pkh without checksum

Harbormaster completed remote builds in B11527: Diff 21466.Jun 16 2020, 18:06
majcosta added a child revision: D6609: [backport#15368] Add checksums to descriptors.md.Jun 16 2020, 18:27
Fabien accepted this revision.Jun 16 2020, 20:08
Fabien added inline comments.
test/functional/wallet_importmulti.py
478 ↗(On Diff #21466)

Nit: use named argument as in the PR

488 ↗(On Diff #21466)

Out of scope: not sure why this one isn't a named argument also

This revision is now accepted and ready to land.Jun 16 2020, 20:08
majcosta updated this revision to Diff 21485.Jun 17 2020, 14:44

rebase

Harbormaster completed remote builds in B11542: Diff 21485.Jun 17 2020, 14:58
Closed by commit rABC8c72f636c0ca: [backport#15368] Make descriptor checksums mandatory in deriveaddresses and… (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 17 2020, 15:51
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC8c72f636c0ca: [backport#15368] Make descriptor checksums mandatory in deriveaddresses and….

Revision Contents
Changeset List

PathSize
src/
rpc/
15 lines
wallet/
2 lines
test/
functional/
38 lines
39 lines

Diff 21488

View Options

src/rpc/misc.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/rpc_deriveaddresses.py

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...