Page MenuHomePhabricator
Differential D6622

[backport#15986] Factor out checksum checking from descriptor parsing
ClosedPublic
Actions

Authored by majcosta on Jun 17 2020, 16:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4757f3807cb5: [backport#15986] Factor out checksum checking from descriptor parsing
Summary

https://github.com/bitcoin/bitcoin/pull/15986/commits/104b3a5069c937383e6f88f2f3fb804ef61b208f

Partial backport of Core PR15986

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 17 2020, 16:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2020, 16:27
majcosta requested review of this revision.Jun 17 2020, 16:27
teamcity edited the summary of this revision. (Show Details)Jun 17 2020, 16:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11544: Diff 21496.Jun 17 2020, 16:49
majcosta added a child revision: D6623: [backport#15986] Add unmodified-but-with-checksum to getdescriptorinfo.Jun 17 2020, 16:53
Fabien accepted this revision.Jun 18 2020, 09:54
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/script/descriptor.cpp
1084 ↗(On Diff #21496)

What about && ?

This revision is now accepted and ready to land.Jun 18 2020, 09:54
Closed by commit rABC4757f3807cb5: [backport#15986] Factor out checksum checking from descriptor parsing (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 18 2020, 15:24
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC4757f3807cb5: [backport#15986] Factor out checksum checking from descriptor parsing.

Revision Contents
Changeset List

PathSize
src/
script/
43 lines

Diff 21524

View Options

src/script/descriptor.cpp

Loading...