Page MenuHomePhabricator
Differential D6623

[backport#15986] Add unmodified-but-with-checksum to getdescriptorinfo
ClosedPublic
Actions

Authored by majcosta on Jun 17 2020, 16:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5b71c0872659: [backport#15986] Add unmodified-but-with-checksum to getdescriptorinfo
Summary

https://github.com/bitcoin/bitcoin/pull/15986/commits/26d3fad1093dfc697048313be7a96c9adf723654

Depends on D6622

Concludes backport of Core PR15986

Test Plan
ninja check
ninja
test_runner.py wallet_address_types

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 17 2020, 16:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2020, 16:53
majcosta requested review of this revision.Jun 17 2020, 16:53
teamcity edited the summary of this revision. (Show Details)Jun 17 2020, 16:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the summary of this revision. (Show Details)Jun 17 2020, 16:53
majcosta added a parent revision: D6622: [backport#15986] Factor out checksum checking from descriptor parsing.
Harbormaster completed remote builds in B11545: Diff 21497.Jun 17 2020, 17:06
Fabien accepted this revision.Jun 18 2020, 09:55
This revision is now accepted and ready to land.Jun 18 2020, 09:55
Closed by commit rABC5b71c0872659: [backport#15986] Add unmodified-but-with-checksum to getdescriptorinfo (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 18 2020, 15:24
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5b71c0872659: [backport#15986] Add unmodified-but-with-checksum to getdescriptorinfo.

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
script/
10 lines
9 lines
test/
functional/
8 lines

Diff 21525

View Options

src/rpc/misc.cpp

Loading...
View Options

src/script/descriptor.h

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

test/functional/wallet_address_types.py

Loading...