Page MenuHomePhabricator
Differential D6664

[backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
ClosedPublic
Actions

Authored by majcosta on Jun 22 2020, 07:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC355883604d02: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet…
Summary

wallet: Remove unreachable code in CreateTransaction
test: Add test for maxtxfee option

Backport of Core PR16322

Test Plan
ninja all check
./test/functional/test_runner.py wallet_create_tx

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 22 2020, 07:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2020, 07:08
majcosta requested review of this revision.Jun 22 2020, 07:08
teamcity edited the summary of this revision. (Show Details)Jun 22 2020, 07:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11602: Diff 21587.Jun 22 2020, 07:23
Fabien accepted this revision.Jun 22 2020, 08:05
This revision is now accepted and ready to land.Jun 22 2020, 08:05
Closed by commit rABC355883604d02: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyJun 22 2020, 09:08
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC355883604d02: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet….

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines
wallet/
21 lines
test/
functional/
2 lines
42 lines

Diff 21594

View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...
View Options

test/functional/wallet_create_tx.py

Loading...