HomePhabricator

[backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet…

Description

[backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction

Summary:
wallet: Remove unreachable code in CreateTransaction
test: Add test for maxtxfee option


Backport of Core PR16322

Test Plan:

ninja all check
./test/functional/test_runner.py wallet_create_tx

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6664

Details

Provenance
João Barbosa <joao.paulo.barbosa@gmail.com>Authored on Jul 2 2019, 14:16
majcostaCommitted on Jun 22 2020, 09:08
majcostaPushed on Jun 22 2020, 09:08
Reviewer
Restricted Project
Differential Revision
D6664: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
Parents
rABCa06ba8d57a91: [backport#14935] tests: Test for expected return values when calling functions…
Branches
Unknown
Tags
Unknown