Page MenuHomePhabricator
Differential D6671

Merge #13457: tests: Drop variadic macro
ClosedPublic
Actions

Authored by nakihito on Jun 22 2020, 18:05.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCedc303d7a396: Merge #13457: tests: Drop variadic macro
Summary

faf52f953b47aac6a39892b037eaa3f08d46b655 tests: Drop variadic macro (MarcoFalke)

Pull request description:

The C++11 constructor of `std::vector` that takes an initializer list, is not `explicit`. Thus, the macro is not required and can be dropped.

Hopefully fixes #13456

Tree-SHA512: 4095ed205f88138a7cd5b14790cc426899966f622a924a9b3f7de646a0d801a48ffb8921da760f1f93d5481298477c8a64dbec291381bb9aa77b075bdd2659f2

Backport of Core PR13457

Test Plan
ninja check

Diff Detail

Event Timeline

nakihito created this revision.Jun 22 2020, 18:05
Owners added a reviewer: Restricted Owners Package.Jun 22 2020, 18:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2020, 18:05
nakihito requested review of this revision.Jun 22 2020, 18:05
teamcity edited the summary of this revision. (Show Details)Jun 22 2020, 18:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Jun 22 2020, 18:14
This revision is now accepted and ready to land.Jun 22 2020, 18:14
Harbormaster completed remote builds in B11613: Diff 21602.Jun 22 2020, 18:16
Closed by commit rABCedc303d7a396: Merge #13457: tests: Drop variadic macro (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 22 2020, 18:22
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCedc303d7a396: Merge #13457: tests: Drop variadic macro.

Revision Contents
Changeset List

PathSize
src/
test/
28 lines

Diff 21602

View Options

src/test/mempool_tests.cpp

Loading...