Page MenuHomePhabricator

Merge #11418: Add error string for CLEANSTACK script violation
ClosedPublic

Authored by jasonbcox on Wed, Jun 24, 00:51.

Details

Summary

cee28fbc3 Add error string for CLEANSTACK script violation, preventing an "unknown error" if the CLEANSTACK error condition is set. (Mark Friedenbach)

Pull request description:

This prevents an unhelpful "unknown error" from being printed in test logs if the CLEANSTACK error condition is set.

Tree-SHA512: cd6764e930184aef3d662e40c67f2ea8aea8552a26d33a567d0315a19d707a82aa2afad9f48ecbb731aa5b77fbbfbd7a6a3a989fdb1424a1181350052ff2a9b5

Backport of Core PR11418

We had applied a similar fix to this previously, but this brings our error message inline with Core's (per feedback from https://github.com/Bitcoin-ABC/bitcoin-abc/issues/393)

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Wed, Jun 24, 00:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jun 24, 00:51
jasonbcox requested review of this revision.Wed, Jun 24, 00:51
teamcity edited the summary of this revision. (Show Details)Wed, Jun 24, 00:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Wed, Jun 24, 00:56
This revision is now accepted and ready to land.Wed, Jun 24, 00:56