Page MenuHomePhabricator
Differential D6713

Merge #14816: Add CScriptNum decode python implementation in functional suite
ClosedPublic
Actions

Authored by jasonbcox on Jun 24 2020, 19:03.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCd6121c79b0a8: Merge #14816: Add CScriptNum decode python implementation in functional suite
Summary

2012d4df2 Add CScriptNum decode python implementation in functional suite (Gregory Sanders)

Pull request description:

I needed this for reasons and thought it'd be good to upsteam it.

Tree-SHA512: 6ea89fa2a5f5a7759ba722f2b4ed5cd6423ebfff4e83ac8b8b5c935e6aa479684e626c5f41fa020816d2a9079a99af5564e30808594d5c13e3b51ec9b474926d

Backport of Core PR14816

Test Plan

test_runner.py mining_basic

Diff Detail

Event Timeline

jasonbcox requested review of this revision.Jun 24 2020, 19:03
jasonbcox created this revision.
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 19:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11673: Diff 21710.Jun 24 2020, 19:14
majcosta accepted this revision.Jun 24 2020, 19:40
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/mining_basic.py
108–115

nit: it'd be nice if the linter picked one layout and stuck to it for readability xD

This revision is now accepted and ready to land.Jun 24 2020, 19:40
Closed by commit rABCd6121c79b0a8: Merge #14816: Add CScriptNum decode python implementation in functional suite (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 24 2020, 20:23
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCd6121c79b0a8: Merge #14816: Add CScriptNum decode python implementation in functional suite.

Revision Contents
Changeset List

PathSize
test/
functional/
20 lines
test_framework/
16 lines

Diff 21710

View Options

test/functional/mining_basic.py

Loading...
View Options

test/functional/test_framework/script.py

Loading...