Differential D6714

[backport#15492 2/2] [cleanup] Remove unused CReserveKey
ClosedPublic
Actions

Authored by majcosta on Jun 24 2020, 19:09.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC08f90b135f33: [backport#15492 2/2] [cleanup] Remove unused CReserveKey

Summary

https://github.com/bitcoin/bitcoin/pull/15748/commits/1b46a4889f894d63062454fb9f4c2e88689a9d75

Depends on D6712

Concludes backport of Core PR15748

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15492_remove_deprecated_generate_method

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11674
Build 22775: Default Diff Build & Tests	Link to the build
Build 22774: Build without Wallet	Link to the build
Build 22773: Build with clang-10	Link to the build
Build 22772: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 24 2020, 19:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 19:09

majcosta requested review of this revision.Jun 24 2020, 19:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11674: Diff 21711.Jun 24 2020, 19:25

majcosta added a child revision: D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.Jun 24 2020, 19:51

majcosta retitled this revision from [backport#15492 2/2] [cleanup] Remove unused CReserveKey [v0.22 ONLY] to [backport#15492 2/2] [cleanup] Remove unused CReserveKey.Jun 28 2020, 21:50

deadalnix accepted this revision.Jun 29 2020, 20:52

This revision is now accepted and ready to land.Jun 29 2020, 20:52

majcosta edited the summary of this revision. (Show Details)Jun 29 2020, 21:23

Closed by commit rABC08f90b135f33: [backport#15492 2/2] [cleanup] Remove unused CReserveKey (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJun 30 2020, 23:43

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC08f90b135f33: [backport#15492 2/2] [cleanup] Remove unused CReserveKey.