Differential D6736

Use reason for checking for sigcheck in txvalidationcache
ClosedPublic
Actions

Authored by deadalnix on Jun 25 2020, 14:42.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC4a7d44cfebb9: Use reason for checking for sigcheck in txvalidationcache

Summary

As per title. This is what we are actually interested in.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

validationcachecleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11702
Build 22878: Default Diff Build & Tests	Link to the build
Build 22877: Build without Wallet	Link to the build
Build 22876: Build with clang-10	Link to the build
Build 22875: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 25 2020, 14:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 25 2020, 14:42

deadalnix requested review of this revision.Jun 25 2020, 14:42

deadalnix added a child revision: D6737: [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible().Jun 25 2020, 14:51

Harbormaster completed remote builds in B11702: Diff 21756.Jun 25 2020, 14:57

jasonbcox accepted this revision.Jun 25 2020, 16:14

This revision is now accepted and ready to land.Jun 25 2020, 16:14

Closed by commit rABC4a7d44cfebb9: Use reason for checking for sigcheck in txvalidationcache (authored by deadalnix). · Explain WhyJun 25 2020, 16:36

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4a7d44cfebb9: Use reason for checking for sigcheck in txvalidationcache.

Revision Contents
Changeset List

Path

Size

src/

test/

txvalidationcache_tests.cpp

8 lines

Diff 21756

View Options

src/test/txvalidationcache_tests.cpp

Use reason for checking for sigcheck in txvalidationcacheClosedPublicActions