Page MenuHomePhabricator

[CI] Run the check target instead of a list of subtargets
ClosedPublic

Authored by Fabien on Mon, Jun 29, 07:28.

Details

Summary

This will cause test_bitcoin to run twice when the run_test_bitcoin
facility is used, but this should not cause any noticeable time penalty
since the tests run in parallel with ninja check. As a reference the
whole ninja check run takes about 5s on my machine.

The main advantage is that it prevents from lowering the coverage when a
test suite is renamed or added.

Test Plan

Run any CI build.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Jun 29, 07:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jun 29, 07:28
Fabien requested review of this revision.Mon, Jun 29, 07:28
deadalnix accepted this revision.Mon, Jun 29, 11:11
This revision is now accepted and ready to land.Mon, Jun 29, 11:11
Fabien updated this revision to Diff 21845.Mon, Jun 29, 11:38

Rebase

This revision was automatically updated to reflect the committed changes.