[avalanche] Manipulate peers via PeerId
ClosedPublic
Actions

Authored by deadalnix on Jun 30 2020, 16:12.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCc23e06f18a83: [avalanche] Manipulate peers via PeerId

Summary

This ensure we do not expose information from internal data structure and can propose a stable API.

Test Plan

ninja all check-avalanche

Repository

rABC Bitcoin ABC

Branch

peerid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11794
Build 23219: Default Diff Build & Tests	Link to the build
Build 23218: Build without Wallet	Link to the build
Build 23217: Build with clang-10	Link to the build
Build 23216: arc lint + arc unit

deadalnix requested review of this revision.Jun 30 2020, 16:12

The nits aren't a big deal, but the comment in selectPeerImpl() needs to be addressed in some way.

src/avalanche/peermanager.cpp
10	Nit: Add a TODO otherwise this comment is confusing
135	I can't find a reference to this behavior in the rest of the code or tests. Assuming this is a mistake, it indicates there's a missing test case somewhere. More specifically, this could impact `selectPeer()` in weird ways.
src/avalanche/peermanager.h
12	Nit: Introduction of PeerId could have been its own diff which would eliminate extra scrolling during review due to extra context in this diff.