Differential D6817

[CI] Improve teamcity error reporting by setting the failure message
ClosedPublic
Actions

Authored by Fabien on Jul 3 2020, 20:11.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rABC04cf5437c814: [CI] Improve teamcity error reporting by setting the failure message

Summary

This turns the build status to failure with a dedicated message when a
timeout occurs, rather than exit code, and sets a better message in all
the other cases. It also makes it possible to search for the error in
the clean log file.

Test Plan

Run any CI build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ci_teamcity_message_build_failed

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11842
Build 23357: Default Diff Build & Tests	Link to the build
Build 23356: Build without Wallet	Link to the build
Build 23355: Build with clang-10	Link to the build
Build 23354: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 3 2020, 20:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2020, 20:11

Fabien requested review of this revision.Jul 3 2020, 20:11

Fabien mentioned this in D6571: [WIP] Test commit, don't review.Jul 3 2020, 20:26

Harbormaster completed remote builds in B11834: Diff 21981.Jul 3 2020, 20:34

Fabien planned changes to this revision.Jul 3 2020, 20:36

Sync to make sure the build logs are complete before aborting

flash => flush

Fabien planned changes to this revision.Jul 3 2020, 20:41

Harbormaster completed remote builds in B11836: Diff 21983.Jul 3 2020, 21:00

Actually write to the log BEFORE publishing the artifacts...
Override the build status message in case of a failure

Harbormaster completed remote builds in B11837: Diff 21984.Jul 3 2020, 21:06

Deduplicate the status message

Don't keep the original message in case of a failure

Harbormaster completed remote builds in B11839: Diff 21986.Jul 3 2020, 21:25

Examples of rendering:
Success: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91213&guest=1
And failure: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91243&guest=1

Harbormaster completed remote builds in B11842: Diff 21989.Jul 3 2020, 21:41

deadalnix accepted this revision.Jul 3 2020, 21:47

This revision is now accepted and ready to land.Jul 3 2020, 21:47

Harbormaster completed remote builds in B11843: Diff 21990.Jul 3 2020, 21:47

jasonbcox accepted this revision.Jul 3 2020, 21:49

Closed by commit rABC04cf5437c814: [CI] Improve teamcity error reporting by setting the failure message (authored by Fabien). · Explain WhyJul 4 2020, 07:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC04cf5437c814: [CI] Improve teamcity error reporting by setting the failure message.

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.py

50 lines

Diff 21989

contrib/teamcity/build-configurations.py

Loading...