Page MenuHomePhabricator

Add flag to enable dst encoding using cashaddr
AbandonedPublic

Authored by dagurval on Nov 14 2017, 14:41.

Details

Reviewers
deadalnix
freetrader
Group Reviewers
Restricted Project
Summary

Adds option -usecashaddr to enable encoding using cashaddr. Defaults to
false.

RPC tests always use the new cashaddr format.

Test Plan

make check, rpc tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
14-11-cashaddr-addflag
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1119
Build 1119: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Nov 14 2017, 15:07
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/base58.cpp
260

?????

src/init.cpp
1578

Put a comment explaining what that is, and put that near to similar parameter if relevant. Maybe near usehd.

This revision now requires changes to proceed.Nov 14 2017, 15:07
src/base58.cpp
260

Fixes syntax error introduced when rebasing D660

src/init.cpp
1578

That's not a good place either. Don't want this to get disabled by ENABLE_WALLET. That means that the help text also can't be in wallet.cpp (as it is now).

I'm putting this under -txindex, since it doesn't really belong in any of the defined groups. Shout if you have a better suggestion.

Move -usecashaddr outside of any group.
Added a comment.
Moved help string.

freetrader added a subscriber: freetrader.

LGTM, tests ok

deadalnix requested changes to this revision.Nov 15 2017, 15:25

Please rebase.

This revision now requires changes to proceed.Nov 15 2017, 15:25

after rebase, arcanist made a new diff instead of updating this one D695