Differential D6845

[avalanche] Rename getSuitableNodeToQuery => selectNode
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2020, 23:31.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCa90587eb13c2: [avalanche] Rename getSuitableNodeToQuery => selectNode

Summary

The name is needlessly redundant, as piking suitable nodes to query is teh whole point of the PeerManager

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 7 2020, 23:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2020, 23:31

deadalnix requested review of this revision.Jul 7 2020, 23:31

Harbormaster completed remote builds in B11889: Diff 22058.Jul 7 2020, 23:47

majcosta accepted this revision.Jul 7 2020, 23:50

This revision is now accepted and ready to land.Jul 7 2020, 23:50

deadalnix added a child revision: D6850: [avalanche] Remove PeerManager::addNodeToPeer.Jul 8 2020, 00:16

Closed by commit rABCa90587eb13c2: [avalanche] Rename getSuitableNodeToQuery => selectNode (authored by deadalnix). · Explain WhyJul 8 2020, 00:20

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCa90587eb13c2: [avalanche] Rename getSuitableNodeToQuery => selectNode.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.h

2 lines

peermanager.cpp

2 lines

processor.cpp

2 lines

test/

peermanager_tests.cpp

12 lines

Diff 22065

View Options

src/avalanche/peermanager.h

View Options

src/avalanche/peermanager.cpp

View Options

src/avalanche/processor.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

[avalanche] Rename getSuitableNodeToQuery => selectNodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22065

src/avalanche/peermanager.h

src/avalanche/peermanager.cpp

src/avalanche/processor.cpp

src/avalanche/test/peermanager_tests.cpp

[avalanche] Rename getSuitableNodeToQuery => selectNode
ClosedPublic
Actions

Revision Contents
Changeset List