Ignore cppcheck error in EraseOrphanTx()
ClosedPublic
Actions

Authored by jasonbcox on Jul 9 2020, 16:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCa70452ac9861: Ignore cppcheck error in EraseOrphanTx()

Summary

This is an unusual case where another container is actually tracking
the iterator of another container. cppcheck iterators1 is clearly useful,
so we do not want to disable it entirely. Instead, we can simply ignore this
one case.

Test Plan

arc lint net_processing.cpp is green after this patch

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 9 2020, 16:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 16:58

jasonbcox requested review of this revision.Jul 9 2020, 16:58

Harbormaster completed remote builds in B11927: Diff 22122.Jul 9 2020, 16:58

jasonbcox added a child revision: D6874: [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders().Jul 9 2020, 16:59

deadalnix accepted this revision.Jul 9 2020, 18:06

This revision is now accepted and ready to land.Jul 9 2020, 18:06

Closed by commit rABCa70452ac9861: Ignore cppcheck error in EraseOrphanTx() (authored by jasonbcox). · Explain WhyJul 9 2020, 18:35

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCa70452ac9861: Ignore cppcheck error in EraseOrphanTx().

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

CppCheckLinter.php

3 lines

Diff 22128

View Options

arcanist/linter/CppCheckLinter.php

Ignore cppcheck error in EraseOrphanTx()ClosedPublicActions