Page MenuHomePhabricator

[validation] Remove error() calls from Invalid() calls
ClosedPublic

Authored by jasonbcox on Jul 9 2020, 17:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfeee46d6ef81: [validation] Remove error() calls from Invalid() calls
Summary

This is in preparation for the next commit, which removes the useless
ret parameter from ValidationState::Invalid().

error() is simply a convenience wrapper that calls LogPrintf and returns
false. Call LogPrintf explicitly and substitute the error() call for a
false bool literal.

Partial backport of Core PR15921 : https://github.com/bitcoin/bitcoin/pull/15921/commits/1a37de4b3174d19a6d8691ae07e92b32fdfaef11

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jul 9 2020, 19:49