Page MenuHomePhabricator
Differential D6876

[validation] Remove error() calls from Invalid() calls
ClosedPublic
Actions

Authored by jasonbcox on Jul 9 2020, 17:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfeee46d6ef81: [validation] Remove error() calls from Invalid() calls
Summary

This is in preparation for the next commit, which removes the useless
ret parameter from ValidationState::Invalid().

error() is simply a convenience wrapper that calls LogPrintf and returns
false. Call LogPrintf explicitly and substitute the error() call for a
false bool literal.

Partial backport of Core PR15921 : https://github.com/bitcoin/bitcoin/pull/15921/commits/1a37de4b3174d19a6d8691ae07e92b32fdfaef11

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 9 2020, 17:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 17:34
jasonbcox requested review of this revision.Jul 9 2020, 17:34
teamcity edited the summary of this revision. (Show Details)Jul 9 2020, 17:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11930: Diff 22125.Jul 9 2020, 17:51
Fabien accepted this revision.Jul 9 2020, 19:49
This revision is now accepted and ready to land.Jul 9 2020, 19:49
Closed by commit rABCfeee46d6ef81: [validation] Remove error() calls from Invalid() calls (authored by jasonbcox). · Explain WhyJul 9 2020, 22:05
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCfeee46d6ef81: [validation] Remove error() calls from Invalid() calls.

Revision Contents
Changeset List

PathSize
src/
99 lines

Diff 22140

View Options

src/validation.cpp

Loading...