Page MenuHomePhabricator
Differential D6877

[backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers
ClosedPublic
Actions

Authored by majcosta on Jul 9 2020, 20:03.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf206c4defc32: [backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers
Summary

https://github.com/bitcoin/bitcoin/pull/16887/commits/230d43fdbc41b356700b0d8a6984d69e00279ade

Partial backport of Core PR16887

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 9 2020, 20:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 20:03
majcosta requested review of this revision.Jul 9 2020, 20:03
teamcity edited the summary of this revision. (Show Details)Jul 9 2020, 20:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6878: [backport#16887 2/3] Add documenting comments to spanparsing.h.Jul 9 2020, 20:05
Harbormaster completed remote builds in B11932: Diff 22129.Jul 9 2020, 20:24
deadalnix accepted this revision.Jul 9 2020, 22:30
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/util/spanparsing.cpp
15 ↗(On Diff #22129)

C++ cast

24 ↗(On Diff #22129)

dito

This revision is now accepted and ready to land.Jul 9 2020, 22:30
Closed by commit rABCf206c4defc32: [backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJul 9 2020, 23:34
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf206c4defc32: [backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers.

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
script/
71 lines
util/
31 lines
66 lines

Diff 22147

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/util/spanparsing.h

Loading...
View Options

src/util/spanparsing.cpp

Loading...