Page MenuHomePhabricator
Differential D6878

[backport#16887 2/3] Add documenting comments to spanparsing.h
ClosedPublic
Actions

Authored by majcosta on Jul 9 2020, 20:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC21181ec40c31: [backport#16887 2/3] Add documenting comments to spanparsing.h
Summary

https://github.com/bitcoin/bitcoin/pull/16887/commits/5e69aeec3f2a0fafd5e591b7222716f00145761d

Depends on D6877

Partial backport of Core PR16887

Test Plan
read the comments

Diff Detail

Event Timeline

majcosta created this revision.Jul 9 2020, 20:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 20:05
majcosta requested review of this revision.Jul 9 2020, 20:05
teamcity edited the summary of this revision. (Show Details)Jul 9 2020, 20:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6879: [backport#16887 3/3] test: add unit tests for Span-parsing helpers.Jul 9 2020, 20:09
Harbormaster completed remote builds in B11933: Diff 22130.Jul 9 2020, 20:28
deadalnix requested changes to this revision.Jul 9 2020, 22:31
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/util/spanparsing.h
15

style

22

dito

30

dito

40

dito

This revision now requires changes to proceed.Jul 9 2020, 22:31
majcosta updated this revision to Diff 22145.Jul 9 2020, 23:19

fix comment formatting

deadalnix accepted this revision.Jul 9 2020, 23:27
This revision is now accepted and ready to land.Jul 9 2020, 23:27
Harbormaster completed remote builds in B11941: Diff 22145.Jul 9 2020, 23:35
Closed by commit rABC21181ec40c31: [backport#16887 2/3] Add documenting comments to spanparsing.h (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJul 9 2020, 23:36
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC21181ec40c31: [backport#16887 2/3] Add documenting comments to spanparsing.h.
majcosta mentioned this in rABC18edda4a16e6: [correction] fix comment style for D6878.Jul 10 2020, 16:09

Revision Contents
Changeset List

PathSize
src/
util/
32 lines

Diff 22130

View Options

src/util/spanparsing.h

Loading...