Page MenuHomePhabricator
Differential D6885

[validation] Remove useless ret parameter from Invalid()
ClosedPublic
Actions

Authored by jasonbcox on Jul 9 2020, 23:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0b39bc3f5a70: [validation] Remove useless ret parameter from Invalid()
Summary

ValidationState::Invalid() takes a parameter ret which is returned to
the caller. All call sites set this to false. Remove the ret parameter
and just return false always.

Partial backport of Core PR15921 : https://github.com/bitcoin/bitcoin/pull/15921/commits/7204c6434b944f6ad51b3c895837729d3aa56eea

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 9 2020, 23:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 23:05
jasonbcox requested review of this revision.Jul 9 2020, 23:05
teamcity edited the summary of this revision. (Show Details)Jul 9 2020, 23:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11940: Diff 22144.Jul 9 2020, 23:24
Fabien accepted this revision.Jul 10 2020, 07:00
This revision is now accepted and ready to land.Jul 10 2020, 07:00
Closed by commit rABC0b39bc3f5a70: [validation] Remove useless ret parameter from Invalid() (authored by jasonbcox). · Explain WhyJul 10 2020, 15:57
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC0b39bc3f5a70: [validation] Remove useless ret parameter from Invalid().

Revision Contents
Changeset List

PathSize
src/
consensus/
35 lines
23 lines
6 lines
129 lines

Diff 22167

View Options

src/consensus/tx_check.cpp

Loading...
View Options

src/consensus/tx_verify.cpp

Loading...
View Options

src/consensus/validation.h

Loading...
View Options

src/validation.cpp

Loading...