Page MenuHomePhabricator

[validation] Remove useless ret parameter from Invalid()
ClosedPublic

Authored by jasonbcox on Jul 9 2020, 23:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0b39bc3f5a70: [validation] Remove useless ret parameter from Invalid()
Summary

ValidationState::Invalid() takes a parameter ret which is returned to
the caller. All call sites set this to false. Remove the ret parameter
and just return false always.

Partial backport of Core PR15921 : https://github.com/bitcoin/bitcoin/pull/15921/commits/7204c6434b944f6ad51b3c895837729d3aa56eea

Test Plan

ninja check check-functional

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jul 10 2020, 07:00