Differential D6965

[refactor] access mapBlockIndex via function in Avalanche code
ClosedPublic
Actions

Authored by majcosta on Jul 17 2020, 19:26.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCcea7b22fdb0f: [refactor] access mapBlockIndex via function in Avalanche code

Summary

incoming PR16194 is encapsulating that global within the BlockManager
object, this part of the code is still accessing it directly, so I
changed it to use the function here, as not to make the backport
needlessly more complicated to review

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 17 2020, 19:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2020, 19:26

majcosta requested review of this revision.Jul 17 2020, 19:26

forgot the tests

Harbormaster completed remote builds in B12046: Diff 22339.Jul 17 2020, 19:41

scratch that

majcosta added a child revision: D6966: [lint] update Avalanche change to circular dep status.Jul 17 2020, 20:03

deadalnix accepted this revision.Jul 17 2020, 22:10

This revision is now accepted and ready to land.Jul 17 2020, 22:10

Closed by commit rABCcea7b22fdb0f: [refactor] access mapBlockIndex via function in Avalanche code (authored by majcosta). · Explain WhyJul 20 2020, 15:52

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCcea7b22fdb0f: [refactor] access mapBlockIndex via function in Avalanche code.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

11 lines

net_processing.cpp

7 lines

Diff 22368

View Options

src/avalanche/processor.cpp