Page MenuHomePhabricator

[backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex
ClosedPublic

Authored by majcosta on Jul 17 2020, 20:19.

Details

Summary

Prevents BlockManager from having to reference ChainstateActive()
within one of its methods which improves encapsulation and makes
testing easier.

https://github.com/bitcoin/bitcoin/pull/16194/commits/4ed55dfcd7894fd5ba6395f244a17ab1f8e786d4


Depends on D6959

Partial backport of Core PR16194

Test Plan
ninja check && ninja check-functional

Event Timeline

deadalnix requested changes to this revision.Jul 17 2020, 22:12
deadalnix added a subscriber: deadalnix.

Please fix description to tell us what it is about.

This revision now requires changes to proceed.Jul 17 2020, 22:12
majcosta edited the summary of this revision. (Show Details)

fixed link to PR and added one to the Core commit

This revision is now accepted and ready to land.Jul 17 2020, 23:13