Page MenuHomePhabricator
Differential D6973

[GITIAN] Don't ignore target-bin/
ClosedPublic
Actions

Authored by Fabien on Jul 20 2020, 13:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC2ea91fae53f6: [GITIAN] Don't ignore target-bin/
Summary

This fixes an issue introduced by
https://github.com/devrandom/gitian-builder/pull/206.
The target-* pattern not only matches the target image name but also
the target-bin directory which contains useful files.

This allows for adding the missing files as well.

Depends on D6972.

Test Plan
NOP()

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 20 2020, 13:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2020, 13:25
Fabien requested review of this revision.Jul 20 2020, 13:25
Fabien added a child revision: D6974: [CMAKE] Don't distribute gitian as part of our sources package.Jul 20 2020, 13:33
Fabien added a child revision: D6976: [GITIAN] Update scripts and docs to use the local gitian version.Jul 20 2020, 13:47
Harbormaster completed remote builds in B12060: Diff 22357.Jul 20 2020, 13:51
deadalnix requested changes to this revision.Jul 20 2020, 14:26
deadalnix added a subscriber: deadalnix.

There is way more code in there than the description addresses. What is this, what does it do?

This revision now requires changes to proceed.Jul 20 2020, 14:26
Fabien requested review of this revision.Jul 20 2020, 14:44
Fabien edited the summary of this revision. (Show Details)
Fabien edited the summary of this revision. (Show Details)

It adds the target-bin directory which was previously ignored due to the bad pattern in the .gitignore file.

deadalnix accepted this revision.Jul 20 2020, 16:10
This revision is now accepted and ready to land.Jul 20 2020, 16:10
Closed by commit rABC2ea91fae53f6: [GITIAN] Don't ignore target-bin/ (authored by Fabien). · Explain WhyJul 20 2020, 21:38
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2ea91fae53f6: [GITIAN] Don't ignore target-bin/.

Revision Contents
Changeset List

PathSize
contrib/
gitian-builder/
1 line
target-bin/
40 lines
13 lines
7 lines
15 lines

Diff 22378

View Options

contrib/gitian-builder/.gitignore

Loading...
View Options

contrib/gitian-builder/target-bin/bootstrap-fixup.in

Loading...
View Options

contrib/gitian-builder/target-bin/grab-packages.sh

Loading...
View Options

contrib/gitian-builder/target-bin/init-build.sh

Loading...
View Options

contrib/gitian-builder/target-bin/upgrade-system.sh

Loading...