Page MenuHomePhabricator

[GITIAN] Don't ignore target-bin/
ClosedPublic

Authored by Fabien on Jul 20 2020, 13:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC2ea91fae53f6: [GITIAN] Don't ignore target-bin/
Summary

This fixes an issue introduced by
https://github.com/devrandom/gitian-builder/pull/206.
The target-* pattern not only matches the target image name but also
the target-bin directory which contains useful files.

This allows for adding the missing files as well.

Depends on D6972.

Test Plan
NOP()

Event Timeline

Fabien requested review of this revision.Jul 20 2020, 13:25
deadalnix requested changes to this revision.Jul 20 2020, 14:26
deadalnix added a subscriber: deadalnix.

There is way more code in there than the description addresses. What is this, what does it do?

This revision now requires changes to proceed.Jul 20 2020, 14:26
Fabien requested review of this revision.Jul 20 2020, 14:44
Fabien edited the summary of this revision. (Show Details)
Fabien edited the summary of this revision. (Show Details)

It adds the target-bin directory which was previously ignored due to the bad pattern in the .gitignore file.

This revision is now accepted and ready to land.Jul 20 2020, 16:10
This revision was automatically updated to reflect the committed changes.