Page MenuHomePhabricator
Differential D699

First patch to prepare tests for explicit Amount constructor
ClosedPublic
Actions

Authored by schancel on Nov 16 2017, 03:22.

Details

Reviewers
deadalnix
freetrader
mbhinder
Group Reviewers
Restricted Project
Commits
rSTAGINGedb5eec34bc3: First patch to prepare tests for explicit Amount constructor
rABCedb5eec34bc3: First patch to prepare tests for explicit Amount constructor
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Nov 16 2017, 03:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 03:22
deadalnix requested changes to this revision.Nov 16 2017, 22:50
deadalnix added inline comments.
src/test/amount_tests.cpp
64 ↗(On Diff #1787)

You removed modulus tests. Granted in that shape they test nothing, but we should test the function defined in amount.h .

90 ↗(On Diff #1787)

Put the comment in the previous line.

102 ↗(On Diff #1787)

dito

This revision now requires changes to proceed.Nov 16 2017, 22:50
schancel updated this revision to Diff 1807.Nov 16 2017, 23:25

Add modulus tests

deadalnix accepted this revision.Nov 22 2017, 19:40
This revision is now accepted and ready to land.Nov 22 2017, 19:40
Closed by commit rABCedb5eec34bc3: First patch to prepare tests for explicit Amount constructor (authored by schancel). · Explain WhyNov 23 2017, 02:18
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1810

View Options

src/test/DoS_tests.cpp

Loading...
View Options

src/test/amount_tests.cpp

Loading...
View Options

src/test/blockcheck_tests.cpp

Loading...
View Options

src/test/blockencodings_tests.cpp

Loading...