Page MenuHomePhabricator

First patch to prepare tests for explicit Amount constructor
ClosedPublic

Authored by schancel on Nov 16 2017, 03:22.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tests1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1145
Build 1145: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Nov 16 2017, 22:50
deadalnix added inline comments.
src/test/amount_tests.cpp
64

You removed modulus tests. Granted in that shape they test nothing, but we should test the function defined in amount.h .

90

Put the comment in the previous line.

102

dito

This revision now requires changes to proceed.Nov 16 2017, 22:50
This revision is now accepted and ready to land.Nov 22 2017, 19:40
This revision was automatically updated to reflect the committed changes.