Page MenuHomePhabricator

[backport#15530] doc: Move wallet lock annotations to header
ClosedPublic

Authored by majcosta on Thu, Jul 23, 01:09.

Details

Summary

faebd2ef40 doc: Move wallet lock annotations to header (MarcoFalke)

Pull request description:

We put the annotations in a central place (the header) as opposed to spreading them over the cpp files, where they easily get outdated.

https://github.com/bitcoin/bitcoin/pull/15530/commits/faebd2ef40bf6c9209110ad4e229e5a207b9c9da

Backport of Core PR15530

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 23, 01:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 23, 01:09
majcosta requested review of this revision.Thu, Jul 23, 01:09
Fabien added a subscriber: Fabien.Thu, Jul 23, 08:04
Fabien added inline comments.
src/wallet/wallet.cpp
3085 ↗(On Diff #22434)

Why was the lock missing here ? Are you missing a dependency ?

src/wallet/wallet.h
804 ↗(On Diff #22434)

I guess it was too difficult to make it consistent with the syntax used 3 lines below...

deadalnix requested changes to this revision.Thu, Jul 23, 11:27
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/wallet.cpp
3085 ↗(On Diff #22434)

+1

This revision now requires changes to proceed.Thu, Jul 23, 11:27
majcosta requested review of this revision.Thu, Jul 23, 13:17
majcosta marked 3 inline comments as done.
majcosta added inline comments.
src/wallet/wallet.cpp
3085 ↗(On Diff #22434)

That one was hiding in an RBF backport and didn't make it in: https://github.com/bitcoin/bitcoin/pull/9697/commits/2ec911f60dc89133ffcf91a6deccc2c7ddb434e6

src/wallet/wallet.h
804 ↗(On Diff #22434)

sry I'll change that XD

majcosta updated this revision to Diff 22469.Thu, Jul 23, 15:36
majcosta marked 2 inline comments as done.

changed nWalletVersion initialization not to stick out like a sore thumb compared to the rest of the code

deadalnix accepted this revision.Fri, Jul 24, 13:59
This revision is now accepted and ready to land.Fri, Jul 24, 13:59
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.