[backport#15530] doc: Move wallet lock annotations to header
ClosedPublic
Actions

Authored by majcosta on Jul 23 2020, 01:09.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

Summary

faebd2ef40 doc: Move wallet lock annotations to header (MarcoFalke)

Pull request description:

We put the annotations in a central place (the header) as opposed to spreading them over the cpp files, where they easily get outdated.

Backport of Core PR15530

Test Plan

ninja check check-functional

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

majcosta requested review of this revision.Jul 23 2020, 01:09

Fabien added inline comments.

src/wallet/wallet.cpp
3085 ↗	(On Diff #22434)	Why was the lock missing here ? Are you missing a dependency ?
src/wallet/wallet.h
804 ↗	(On Diff #22434)	I guess it was too difficult to make it consistent with the syntax used 3 lines below...

deadalnix requested changes to this revision.Jul 23 2020, 11:27

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/wallet/wallet.cpp
3085 ↗	(On Diff #22434)	+1

This revision now requires changes to proceed.Jul 23 2020, 11:27

majcosta requested review of this revision.Jul 23 2020, 13:17

majcosta marked 3 inline comments as done.

majcosta added inline comments.

src/wallet/wallet.cpp
3085 ↗	(On Diff #22434)	That one was hiding in an RBF backport and didn't make it in: https://github.com/bitcoin/bitcoin/pull/9697/commits/2ec911f60dc89133ffcf91a6deccc2c7ddb434e6
src/wallet/wallet.h
804 ↗	(On Diff #22434)	sry I'll change that XD