Page MenuHomePhabricator
Differential D7039

[backport#16451 2/3][wallet] Flatten CWalletTx class hierarchy
ClosedPublic
Actions

Authored by majcosta on Jul 25 2020, 07:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd5d0327a58df: [backport#16451 2/3][wallet] Flatten CWalletTx class hierarchy
Summary

Removes CMerkleTx as a base class for CWalletTx. Serialization logic is
moved from CMerkleTx to CWalletTx.

https://github.com/bitcoin/bitcoin/pull/16451/commits/783a76f23ba4f33b6e6f609eaf3bf41afd9bcd6f

Depends on D7038

Partial backport of Core PR16451

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 25 2020, 07:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2020, 07:15
majcosta requested review of this revision.Jul 25 2020, 07:15
majcosta added a child revision: D7040: [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic.
Harbormaster completed remote builds in B12159: Diff 22509.Jul 25 2020, 07:30
deadalnix accepted this revision.Jul 25 2020, 13:05
This revision is now accepted and ready to land.Jul 25 2020, 13:05
Closed by commit rABCd5d0327a58df: [backport#16451 2/3][wallet] Flatten CWalletTx class hierarchy (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJul 26 2020, 13:53
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd5d0327a58df: [backport#16451 2/3][wallet] Flatten CWalletTx class hierarchy.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
55 lines

Diff 22522

View Options

src/wallet/wallet.h

Loading...