Page MenuHomePhabricator

[backport#16451 3/3][wallet] Remove CMerkleTx serialization logic
ClosedPublic

Authored by majcosta on Sat, Jul 25, 07:17.

Details

Summary

CMerkleTx is only used for deserialization of old wallet files. Remove
the serialization logic, and tidy up CWalletTx serialization logic.

https://github.com/bitcoin/bitcoin/pull/16451/commits/05b56d1c937b7667ad51400d2f9fb674af72953f


Depends on D7039

Concludes backport of Core PR16451

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Sat, Jul 25, 07:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jul 25, 07:17
majcosta requested review of this revision.Sat, Jul 25, 07:17
majcosta retitled this revision from [backport#16451][wallet] Remove CMerkleTx serialization logic to [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic.Sat, Jul 25, 07:18
deadalnix accepted this revision.Sat, Jul 25, 13:06
This revision is now accepted and ready to land.Sat, Jul 25, 13:06
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.