Page MenuHomePhabricator

Do not generate RPC doc index files multiple times
ClosedPublic

Authored by jasonbcox on Tue, Jul 28, 23:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC97fe5d3a8660: Do not generate RPC doc index files multiple times
Summary

See title. The loop is not constructed properly.

Test Plan
build-configurations.py build-docs
cat abc-ci-builds/build-docs/doc/rpc/en/0.21.13/index.md
cat abc-ci-builds/build-docs/doc/rpc/en/0.21.13/rpc/index.md

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Tue, Jul 28, 23:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 28, 23:25
jasonbcox requested review of this revision.Tue, Jul 28, 23:25
Fabien accepted this revision.Wed, Jul 29, 08:51
Fabien added a subscriber: Fabien.

Note that you still need to build an index per group (so within the loop), despite this is not what is done here.

This revision is now accepted and ready to land.Wed, Jul 29, 08:51

Note that you still need to build an index per group (so within the loop), despite this is not what is done here.

ya, that's going to be a followup to this diff

jasonbcox updated this revision to Diff 22625.Wed, Jul 29, 23:17

Rebase (doesn't really depend on D7065)

Snippet of first build failure:

[314/370] bitcoin: testing torcontrol_tests
[315/370] bitcoin: testing timedata_tests
[316/370] Running utility command for check-bitcoin-torcontrol_tests
[317/370] bitcoin: testing streams_tests
[318/370] bitcoin: testing settings_tests
[319/370] Running utility command for check-bitcoin-timedata_tests
[320/370] bitcoin: testing checkdatasig_tests
[321/370] Running utility command for check-bitcoin-streams_tests
[322/370] Running utility command for check-bitcoin-settings_tests
[323/370] Running utility command for check-bitcoin-checkdatasig_tests
[324/370] bitcoin: testing policyestimator_tests
[325/370] bitcoin: testing uint256_tests
[326/370] Running utility command for check-bitcoin-policyestimator_tests
[327/370] Running utility command for check-bitcoin-uint256_tests
[328/370] bitcoin: testing validationinterface_tests
[329/370] bitcoin: testing undo_tests
[330/370] bitcoin: testing checkpoints_tests
[331/370] Running utility command for check-bitcoin-validationinterface_tests
[332/370] Running utility command for check-bitcoin-undo_tests
[333/370] Running utility command for check-bitcoin-checkpoints_tests
[334/370] bitcoin: testing cashaddr_tests
[335/370] Running utility command for check-bitcoin-cashaddr_tests
[336/370] bitcoin: testing getarg_tests
[337/370] Running utility command for check-bitcoin-getarg_tests
[338/370] bitcoin: testing serialize_tests
[339/370] bitcoin: testing bswap_tests
[340/370] Running utility command for check-bitcoin-serialize_tests
[341/370] bitcoin: testing hash_tests
[342/370] Running utility command for check-bitcoin-bswap_tests
[343/370] Running utility command for check-bitcoin-hash_tests
[344/370] bitcoin: testing crypto_tests
[345/370] Running utility command for check-bitcoin-crypto_tests
[346/370] bitcoin: testing versionbits_tests
[347/370] bitcoin: testing txvalidation_tests
[348/370] Running utility command for check-bitcoin-versionbits_tests
[349/370] Running utility command for check-bitcoin-txvalidation_tests
[350/370] bitcoin: testing monolith_opcodes_tests
[351/370] Running utility command for check-bitcoin-monolith_opcodes_tests
[352/370] bitcoin: testing radix_tests
[353/370] Running utility command for check-bitcoin-radix_tests
[354/370] bitcoin: testing sigencoding_tests
[355/370] Running utility command for check-bitcoin-sigencoding_tests
[356/370] bitcoin: testing validation_tests
[357/370] Running utility command for check-bitcoin-validation_tests
[358/370] bitcoin: testing compress_tests
[359/370] Running utility command for check-bitcoin-compress_tests
[360/370] bitcoin: testing skiplist_tests
[361/370] Running utility command for check-bitcoin-skiplist_tests
[362/370] bitcoin: testing op_reversebytes_tests
[363/370] Running utility command for check-bitcoin-op_reversebytes_tests
[364/370] bitcoin: testing cuckoocache_tests
[365/370] Running utility command for check-bitcoin-cuckoocache_tests
[366/370] bitcoin: testing coins_tests
[367/370] Running utility command for check-bitcoin-coins_tests
[368/370] bitcoin: testing transaction_tests
[369/370] Running utility command for check-bitcoin-transaction_tests
[370/370] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_bind.py

This revision was automatically updated to reflect the committed changes.