Page MenuHomePhabricator
Differential D7073

[CMAKE] Bump minimum cmake to 3.16
ClosedPublic
Actions

Authored by Fabien on Jul 29 2020, 12:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCc94fb65cf8be: [CMAKE] Bump minimum cmake to 3.16
Summary

This is the version from Debian Buster backports. It fixes a couple
issues, and it required for some more coming features (e.g. D6751).

Depends on D7072 to prevent to Gitian builds from failing.

Test Plan

Read the docs and try the instructions.

cmake -GNinja ..
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 29 2020, 12:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2020, 12:50
Fabien requested review of this revision.Jul 29 2020, 12:50
Fabien added a child revision: D6751: [CMAKE] Run the leveldb tests serially.Jul 29 2020, 13:06
Harbormaster completed remote builds in B12215: Diff 22602.Jul 29 2020, 13:13
jasonbcox requested changes to this revision.Jul 29 2020, 16:21
jasonbcox added a subscriber: jasonbcox.

Version bump is missing from contrib/debian/control. Please add this to the test plan also.

This revision now requires changes to proceed.Jul 29 2020, 16:21
Fabien updated this revision to Diff 22617.Jul 29 2020, 20:15

Update debian control file

Fabien added a comment.Jul 29 2020, 20:17

Updating the test plan is not really necessary as the PPA build already uses cmake 3.17.

Harbormaster completed remote builds in B12234: Diff 22617.Jul 29 2020, 20:35
jasonbcox accepted this revision.Jul 29 2020, 22:25
This revision is now accepted and ready to land.Jul 29 2020, 22:25
Closed by commit rABCc94fb65cf8be: [CMAKE] Bump minimum cmake to 3.16 (authored by Fabien). · Explain WhyJul 30 2020, 22:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc94fb65cf8be: [CMAKE] Bump minimum cmake to 3.16.
Fabien mentioned this in D7101: [TRAVIS] Install cmake version 3.16.Jul 31 2020, 08:30
Fabien mentioned this in rABCb7212989f020: [TRAVIS] Install cmake version 3.16.Jul 31 2020, 13:35

Revision Contents
Changeset List

PathSize
2 lines
contrib/
debian/
2 lines
teamcity/
2 lines
doc/
10 lines
2 lines
src/
27 lines
leveldb/
13 lines
secp256k1/
2 lines
univalue/
2 lines

Diff 22652

View Options

CMakeLists.txt

Loading...
View Options

contrib/debian/control

Loading...
View Options

contrib/teamcity/setup-debian-buster.sh

Loading...
View Options

doc/build-unix.md

Loading...
View Options

doc/dependencies.md

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/leveldb/CMakeLists.txt

Loading...
View Options

src/secp256k1/CMakeLists.txt

Loading...
View Options

src/univalue/CMakeLists.txt

Loading...