Page MenuHomePhabricator

[CMAKE] Bump minimum cmake to 3.16
ClosedPublic

Authored by Fabien on Wed, Jul 29, 12:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCc94fb65cf8be: [CMAKE] Bump minimum cmake to 3.16
Summary

This is the version from Debian Buster backports. It fixes a couple
issues, and it required for some more coming features (e.g. D6751).

Depends on D7072 to prevent to Gitian builds from failing.

Test Plan

Read the docs and try the instructions.

cmake -GNinja ..
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Jul 29, 12:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 29, 12:50
Fabien requested review of this revision.Wed, Jul 29, 12:50
jasonbcox requested changes to this revision.Wed, Jul 29, 16:21
jasonbcox added a subscriber: jasonbcox.

Version bump is missing from contrib/debian/control. Please add this to the test plan also.

This revision now requires changes to proceed.Wed, Jul 29, 16:21
Fabien updated this revision to Diff 22617.Wed, Jul 29, 20:15

Update debian control file

Fabien added a comment.Wed, Jul 29, 20:17

Updating the test plan is not really necessary as the PPA build already uses cmake 3.17.

jasonbcox accepted this revision.Wed, Jul 29, 22:25
This revision is now accepted and ready to land.Wed, Jul 29, 22:25
This revision was automatically updated to reflect the committed changes.