Page MenuHomePhabricator

[CMAKE] Bump minimum cmake to 3.16
ClosedPublic

Authored by Fabien on Jul 29 2020, 12:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCc94fb65cf8be: [CMAKE] Bump minimum cmake to 3.16
Summary

This is the version from Debian Buster backports. It fixes a couple
issues, and it required for some more coming features (e.g. D6751).

Depends on D7072 to prevent to Gitian builds from failing.

Test Plan

Read the docs and try the instructions.

cmake -GNinja ..
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jul 29 2020, 12:50
jasonbcox requested changes to this revision.Jul 29 2020, 16:21
jasonbcox added a subscriber: jasonbcox.

Version bump is missing from contrib/debian/control. Please add this to the test plan also.

This revision now requires changes to proceed.Jul 29 2020, 16:21

Update debian control file

Updating the test plan is not really necessary as the PPA build already uses cmake 3.17.

This revision is now accepted and ready to land.Jul 29 2020, 22:25
This revision was automatically updated to reflect the committed changes.