rpc
AbandonedPublic
Actions

Authored by jasonbcox on Jul 30 2020, 00:20.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Summary

This patch is the first step to a real index page that
integrates into the rest of the site. It currently only lists
links to RPCs by group, so there is a lot of room for improvement
such as sub-lists of the RPC commands themselves. These can come
in later diffs.

Test Plan

contrib/teamcity/build-configurations.py build-docs
cat abc-ci-builds/build-docs/doc/rpc/en/0.21.13/rpc/index.md

Diff Detail

Repository

rABC Bitcoin ABC

Branch

doc-rpc-index

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12240
Build 24694: Default Diff Build & Tests	build-diff
Build 24693: Build without Wallet	build-without-wallet
Build 24692: Build with clang-10	build-clang-10
Build 24691: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 30 2020, 00:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 30 2020, 00:20

jasonbcox requested review of this revision.Jul 30 2020, 00:20

Harbormaster completed remote builds in B12240: Diff 22628.Jul 30 2020, 00:48

Fabien accepted this revision.Jul 30 2020, 08:49

This revision is now accepted and ready to land.Jul 30 2020, 08:49

deadalnix requested changes to this revision.Jul 30 2020, 12:11

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

doc/rpc/generate.go
163	The whole point of having templates is to do this.

This revision now requires changes to proceed.Jul 30 2020, 12:11

I think you are going the completely wrong road here. Jeckyl seems to be perfectly able to generate all the crap that is necessary for indices and all. This is completely breaking the SRP. The goal of that script is to extract infos from the node. The goal of the jeckyl machinery to to put it in proper form.

See D7130 and associated stack.