Page MenuHomePhabricator

Support cashaddr in parse/format URI
ClosedPublic

Authored by dagurval on Nov 23 2017, 14:58.

Details

Summary

Depends on D708

Test Plan

added tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix requested changes to this revision.Nov 23 2017, 15:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/guiutil.cpp
177 ↗(On Diff #1817)

This should be able to detect which kind of addresses we are looking at rather than blindly trusting the config.

src/qt/test/uritests.cpp
26 ↗(On Diff #1817)

This whole test should work with and without cashaddr enabled.

99 ↗(On Diff #1817)

dito

200 ↗(On Diff #1817)

likestamp

This revision now requires changes to proceed.Nov 23 2017, 15:11

Check if URI is cashaddr encoded instead of relying on user config

This should be able to detect which kind of addresses we are looking at rather than blindly trusting the config.

Good idea. This simplifies this change also, since cfg no longer has to be passed to parseBitcoinURI

deadalnix requested changes to this revision.Nov 29 2017, 21:04

Back on your queue

This revision now requires changes to proceed.Nov 29 2017, 21:04
This revision is now accepted and ready to land.Nov 30 2017, 15:56
This revision was automatically updated to reflect the committed changes.