Page MenuHomePhabricator
Differential D709

Support cashaddr in parse/format URI
ClosedPublic
Actions

Authored by dagurval on Nov 23 2017, 14:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING9350110492c6: Support cashaddr in parse/format URI
rABC9350110492c6: Support cashaddr in parse/format URI
Summary

Depends on D708

Test Plan

added tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dagurval created this revision.Nov 23 2017, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2017, 14:58
dagurval edited the summary of this revision. (Show Details)Nov 23 2017, 14:58
dagurval added a parent revision: D708: Make Config more available in Qt.
deadalnix requested changes to this revision.Nov 23 2017, 15:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/guiutil.cpp
177 ↗(On Diff #1817)

This should be able to detect which kind of addresses we are looking at rather than blindly trusting the config.

src/qt/test/uritests.cpp
26 ↗(On Diff #1817)

This whole test should work with and without cashaddr enabled.

99 ↗(On Diff #1817)

dito

200 ↗(On Diff #1817)

likestamp

This revision now requires changes to proceed.Nov 23 2017, 15:11
dagurval updated this revision to Diff 1861.Nov 27 2017, 08:27

Check if URI is cashaddr encoded instead of relying on user config

dagurval added a comment.Nov 27 2017, 08:28

This should be able to detect which kind of addresses we are looking at rather than blindly trusting the config.

Good idea. This simplifies this change also, since cfg no longer has to be passed to parseBitcoinURI

dagurval mentioned this in D583: Support parsing cashaddr from command line.Nov 27 2017, 13:28
dagurval added a child revision: D583: Support parsing cashaddr from command line.Nov 27 2017, 13:31
deadalnix requested changes to this revision.Nov 29 2017, 21:04

Back on your queue

This revision now requires changes to proceed.Nov 29 2017, 21:04
deadalnix accepted this revision.Nov 30 2017, 15:56
This revision is now accepted and ready to land.Nov 30 2017, 15:56
Closed by commit rABC9350110492c6: Support cashaddr in parse/format URI (authored by dagurval). · Explain WhyDec 6 2017, 21:58
This revision was automatically updated to reflect the committed changes.
deadalnix mentioned this in D765: Revert support cashaddr in parse/format URI.Dec 7 2017, 00:12

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
22 lines
2 lines
4 lines
test/
4 lines
119 lines

Diff 1971

View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/receivecoinsdialog.cpp

Loading...
View Options

src/qt/receiverequestdialog.cpp

Loading...
View Options

src/qt/test/uritests.h

Loading...
View Options

src/qt/test/uritests.cpp

Loading...