Page MenuHomePhabricator
Differential D539

qt: Use IsMine to validate custom change address
ClosedPublic
Actions

Authored by dagurval on Sep 13 2017, 13:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe2ecbe002807: qt: Use IsMine to validate custom change address
rABCe2ecbe002807: qt: Use IsMine to validate custom change address
Summary

Port of https://github.com/bitcoin/bitcoin/pull/11247

Test Plan

As part of next diff

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dagurval created this revision.Sep 13 2017, 13:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2017, 13:28
Harbormaster completed remote builds in B859: Diff 1367.Sep 13 2017, 13:28
dagurval added a child revision: D540: Introduce wrappers around CBitcoinAddress.Sep 13 2017, 13:47
deadalnix requested changes to this revision.Sep 14 2017, 16:45
deadalnix added a subscriber: deadalnix.

Honestly I'm not sure what this code is doing. It is rather concerning that changing it that way doesn't require changing any test. What would it take to write a test for this ?

src/qt/sendcoinsdialog.cpp
836 ↗(On Diff #1367)

Please keep the comment within the blocks.

840 ↗(On Diff #1367)

dito

This revision now requires changes to proceed.Sep 14 2017, 16:45
deadalnix added a comment.Sep 14 2017, 16:53

Looking at D540, I understand this better. It still would be beneficial to see if that can be unit tested in some way.

dagurval updated this revision to Diff 1387.Sep 17 2017, 21:01
dagurval edited edge metadata.

formatting

Harbormaster completed remote builds in B874: Diff 1387.Sep 17 2017, 21:01
dagurval marked 2 inline comments as done.Sep 17 2017, 21:15

Rebased and pushed formatting changes.

I don't see how SendCoinsDialog would be testable at all. WalletModel may be testable with some work.

But at least the IsMine function has some test coverage.

deadalnix accepted this revision.Sep 21 2017, 19:24
This revision is now accepted and ready to land.Sep 21 2017, 19:24
Closed by commit rABCe2ecbe002807: qt: Use IsMine to validate custom change address (authored by Chris Moore <dooglus@gmail.com>, committed by dagurval). · Explain WhySep 21 2017, 23:40
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
10 lines
2 lines
4 lines

Diff 1401

View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...