Differential D7090

[backport#17138 1/2][wallet] Remove package limit config access from wallet
ClosedPublic
Actions

Authored by majcosta on Jul 30 2020, 18:23.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCae229def7dba: [backport#17138 1/2][wallet] Remove package limit config access from wallet

Summary

The wallet should not be able to directly access global configuration
from the node. Remove access of "-limitancestorcount" and
"-limitdescendantcount".

https://github.com/bitcoin/bitcoin/pull/17138/commits/eea462de9c652dca556ad241d2126b10790f67f8

Partial backport of Core PR17138

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 30 2020, 18:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 30 2020, 18:23

majcosta requested review of this revision.Jul 30 2020, 18:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12246: Diff 22643.Jul 30 2020, 18:35

majcosta added a child revision: D7091: [backport#17138 2/2][wallet] Remove pruning check for -rescan option.Jul 30 2020, 18:35

jasonbcox accepted this revision.Jul 31 2020, 00:19

This revision is now accepted and ready to land.Jul 31 2020, 00:19

Closed by commit rABCae229def7dba: [backport#17138 1/2][wallet] Remove package limit config access from wallet (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJul 31 2020, 00:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCae229def7dba: [backport#17138 1/2][wallet] Remove package limit config access from wallet.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.h

6 lines

chain.cpp

9 lines

wallet/

wallet.cpp

8 lines

Diff 22657

View Options

src/interfaces/chain.h

View Options

src/interfaces/chain.cpp

View Options

[backport#17138 1/2][wallet] Remove package limit config access from walletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22657

src/interfaces/chain.h

src/interfaces/chain.cpp

src/wallet/wallet.cpp

[backport#17138 1/2][wallet] Remove package limit config access from wallet
ClosedPublic
Actions

Revision Contents
Changeset List