Page MenuHomePhabricator

[backport#17138 2/2][wallet] Remove pruning check for -rescan option
ClosedPublic

Authored by majcosta on Thu, Jul 30, 18:35.

Details

Summary

Prior to this PR, the wallet would not allow the -rescan option at
startup if pruning was enabled. This is unnecessarily restrictive. It
should be possible to rescan if pruning is enabled, as long as no blocks
have actually been pruned yet.

Remove the pruning check from WalletInit::ParameterInteraction(). If any
blocks have been pruned, that will be caught in CreateWalletFromFile().

https://github.com/bitcoin/bitcoin/pull/17138/commits/b96ed0396294fc4fa89d83ceab6bc169dd09f002


Depends on D7090

Concludes backport of Core PR17138

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 30, 18:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 30, 18:35
majcosta requested review of this revision.Thu, Jul 30, 18:35
teamcity edited the summary of this revision. (Show Details)Thu, Jul 30, 18:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Fri, Jul 31, 00:18
This revision is now accepted and ready to land.Fri, Jul 31, 00:18