HomePhabricator

[backport#17138 2/2][wallet] Remove pruning check for -rescan option

Authored by John Newbery <john@johnnewbery.com> on Oct 14 2019, 17:39.

Description

[backport#17138 2/2][wallet] Remove pruning check for -rescan option

Summary:
Prior to this PR, the wallet would not allow the -rescan option at
startup if pruning was enabled. This is unnecessarily restrictive. It
should be possible to rescan if pruning is enabled, as long as no blocks
have actually been pruned yet.

Remove the pruning check from WalletInit::ParameterInteraction(). If any
blocks have been pruned, that will be caught in CreateWalletFromFile().

https://github.com/bitcoin/bitcoin/pull/17138/commits/b96ed0396294fc4fa89d83ceab6bc169dd09f002


Depends on D7090

Concludes backport of Core PR17138

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D7091

Details

Committed
majcostaFri, Jul 31, 00:58
Pushed
majcostaFri, Jul 31, 00:58
Reviewer
Restricted Project
Differential Revision
D7091: [backport#17138 2/2][wallet] Remove pruning check for -rescan option
Parents
rABCae229def7dba: [backport#17138 1/2][wallet] Remove package limit config access from wallet
Branches
Unknown
Tags
Unknown