Page MenuHomePhabricator
Differential D7091

[backport#17138 2/2][wallet] Remove pruning check for -rescan option
ClosedPublic
Actions

Authored by majcosta on Jul 30 2020, 18:35.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC756dd8741559: [backport#17138 2/2][wallet] Remove pruning check for -rescan option
Summary

Prior to this PR, the wallet would not allow the -rescan option at
startup if pruning was enabled. This is unnecessarily restrictive. It
should be possible to rescan if pruning is enabled, as long as no blocks
have actually been pruned yet.

Remove the pruning check from WalletInit::ParameterInteraction(). If any
blocks have been pruned, that will be caught in CreateWalletFromFile().

https://github.com/bitcoin/bitcoin/pull/17138/commits/b96ed0396294fc4fa89d83ceab6bc169dd09f002

Depends on D7090

Concludes backport of Core PR17138

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 30 2020, 18:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 30 2020, 18:35
majcosta requested review of this revision.Jul 30 2020, 18:35
teamcity edited the summary of this revision. (Show Details)Jul 30 2020, 18:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12247: Diff 22644.Jul 30 2020, 18:47
jasonbcox accepted this revision.Jul 31 2020, 00:18
This revision is now accepted and ready to land.Jul 31 2020, 00:18
Closed by commit rABC756dd8741559: [backport#17138 2/2][wallet] Remove pruning check for -rescan option (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJul 31 2020, 00:58
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC756dd8741559: [backport#17138 2/2][wallet] Remove pruning check for -rescan option.

Revision Contents
Changeset List

PathSize
src/
wallet/
7 lines

Diff 22658

View Options

src/wallet/init.cpp

Loading...