Page MenuHomePhabricator
Differential D7141

Fix signed shift by 31 bits
ClosedPublic
Actions

Authored by jasonbcox on Aug 6 2020, 17:00.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC6ddc183e2b48: Fix signed shift by 31 bits
Summary

Shifting a signed integer by 31 bits is undefined behavior.

Test Plan
arc lint src/test/op_reversebytes_tests.cpp

Diff Detail

Repository
rABC Bitcoin ABC
Branch
op-rev-cppcheck
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12321
Build 24838: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 24837: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 6 2020, 17:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2020, 17:00
jasonbcox requested review of this revision.Aug 6 2020, 17:00
Harbormaster completed remote builds in B12321: Diff 22767.Aug 6 2020, 17:14
majcosta accepted this revision.Aug 6 2020, 17:27
This revision is now accepted and ready to land.Aug 6 2020, 17:27
Closed by commit rABC6ddc183e2b48: Fix signed shift by 31 bits (authored by jasonbcox). · Explain WhyAug 6 2020, 18:02
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC6ddc183e2b48: Fix signed shift by 31 bits.

Revision Contents
Changeset List

PathSize
src/
test/
2 lines

Diff 22767

View Options

src/test/op_reversebytes_tests.cpp

Loading...